Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coq CI #9

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix Coq CI #9

merged 1 commit into from
Oct 12, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Oct 11, 2024

@liyishuai we need this to keep coq-json compiling in Coq CI (c.f. https://github.com/coq/coq/blob/master/dev/ci/ci-json.sh , it's also the configuration in Compcert and VST makefiles)

@liyishuai liyishuai merged commit 8069b6b into liyishuai:master Oct 12, 2024
8 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Oct 14, 2024

Thanks @liyishuai coq-http is now back in Coq CI: coq/coq#19679
However, next time you plan such a change in the build process of something in Coq CI, please advise Coq devs in advance so as to find a way to minimize diisruption there (with the previous parsec issue, coq-http has been down for more than a week in Coq CI) and, maybe more importantly, Coq dev work to adapt to your changes. Unfortunately, updating opam packages is not enough since Coq CI has its own configuration, not based on opam.
FWIW, I'm also updating the Nix packages: NixOS/nixpkgs#348516

@proux01 proux01 deleted the coq_fix_ci branch October 14, 2024 12:25
@liyishuai
Copy link
Owner

Maybe worth integrating a GitHub action that monitors the OPAM file updates and sends notifications to Coq devs.

@proux01
Copy link
Contributor Author

proux01 commented Oct 15, 2024

Well, most developers don't even think about updating the opam files, you were rather the good student on that front. In any case, this would be too late. No, that kind of things just need to be planned and discussed in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants